[client] Allow inbound rosenpass port #3109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lixmal
force-pushed
the
allow-inbound-rosenpass
branch
from
2836424 to
29e311a
Compare
lixmal
force-pushed
the
allow-inbound-rosenpass
branch
from
29e311a to
61bd7c5
Compare
|
Contributor
Copilot
AI
left a comment
Copilot
AI
left a comment
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
client/internal/engine.go:454
- The parameter name 'error' is misleading and not used within the function. Consider removing it or renaming it to something meaningful.
func (e *Engine) initFirewall(error) error {
| "", | ||
| ); err != nil { | ||
| log.Errorf("failed to allow rosenpass interface traffic: %v", err) | ||
| return nil |
There was a problem hiding this comment.
The function should return the actual error instead of nil when it fails to allow Rosenpass interface traffic.
Suggested change
| return nil | |
| return err |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Checklist