profiles: email-common: refactor #5571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No longer used for claws-mail and sylpheed only.
kmk3
reviewed
Jan 6, 2023
Pointed out in review that this comment was removed by mistake.
rusty-snake
reviewed
Jan 6, 2023
Suggested in review.
Supporting 'level 1 hack' to allow opening hyperlinks with firefox needs xdg-open (besides bash,sh). Adding xdg-open to private-bin is not enough, as it pulls in a long list of other commands and that's pretty unmaintainable IMO. So I opted to drop private-bin here.
|
merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started work for #5305. For now only balsa.profile is fully refactored for email-common.profile. claws-mail and sylpheed already were so those needed just some reshuffling.