Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profiles: mutt: add ~/.mutthistory & reduce amount of paths created #5626

Merged
merged 3 commits into from
Jan 30, 2023

Conversation

kmk3
Copy link
Collaborator

@kmk3 kmk3 commented Jan 28, 2023

Commits:

$ git log --reverse --pretty='* %s' master..
* mutt.profile: add ~/.mutthistory
* mutt.profile: stop creating editor/browser paths
* mutt.profile: stop creating config files for other programs

Relates to #3849 and #5619.

Cc: @bbhtt @hyder365 (from #3849 and #5619)

From the manual of mutt 2.2.9:

> 3.125. history_file
>
>    Type: path
>    Default: "~/.mutthistory"
>
>    The file in which Mutt will save its history.
To reduce the amount of spam created in the user home directory.

It's unlikely that these paths are going to be both:

* Created only after mutt is first opened through firejail and
* Created from within mutt

Also, no other profile does that:

    $ git grep -El '(mkdir|mkfile) \$\{HOME\}/\.(emacs|nano|vim)' -- etc
    etc/profile-m-z/mutt.profile

So just whitelist them if they already exist.

Added on commit a8a8e33 ("Add whitelisting to mutt; improve geary, new
profile for neomutt", 2020-12-28) / PR netblue30#3849.
Let either the respective program or the user create the file.

* ~/.bogofilter: Used by the bogofilter program
* ~/.msmtprc: Used by the msmtp program

Added on commit a8a8e33 ("Add whitelisting to mutt; improve geary, new
profile for neomutt", 2020-12-28) / PR netblue30#3849.
Copy link
Collaborator

@glitsj16 glitsj16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@netblue30 netblue30 merged commit d1e3b8a into netblue30:master Jan 30, 2023
@netblue30
Copy link
Owner

merged!

@kmk3 kmk3 deleted the mutt-reduce-mkdir branch January 30, 2023 19:29
kmk3 added a commit to kmk3/firejail that referenced this pull request Jan 30, 2023
Move some paths from mutt.profile and neomutt.profile.

Added on commit 6b9bfad ("Fix python; add read-only to editors/cli
browsers;re-add cache directory", 2020-12-29) / PR netblue30#3849.

Misc: This is a follow-up to netblue30#5626.
@kmk3 kmk3 changed the title mutt.profile: add ~/.mutthistory & reduce amount of paths created mutt: add ~/.mutthistory & reduce amount of paths created Aug 23, 2024
@kmk3 kmk3 changed the title mutt: add ~/.mutthistory & reduce amount of paths created profiles: mutt: add ~/.mutthistory & reduce amount of paths created Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants