Custom Header Support #1327
Merged
Custom Header Support #1327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clinta
force-pushed
the
custom_headers
branch
3 times, most recently
from
7959ab9
to
a3ca9d9
Compare
clinta
added a commit
to clinta/netbox_ansible_modules
that referenced
this pull request
Sep 26, 2024
clinta
added a commit
to clinta/netbox_ansible_modules
that referenced
this pull request
Sep 26, 2024
clinta
force-pushed
the
custom_headers
branch
from
63fe06e
to
d43e8c6
Compare
clinta
force-pushed
the
custom_headers
branch
from
d43e8c6
to
7b9df55
Compare
sc68cal
approved these changes
Sep 26, 2024
|
Waiting for other maintainers to approve & merge since I prefer not to merge things without consensus |
|
Haven't seen any other maintainers 👎 this so I'll merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
#896
New Behavior
This PR adds the ability to add custom headers to the API requests for both the inventory and lookup module. It supports headers in the module arguments, or as an environment variable in JSON format.
Contrast to Current Behavior
Currently there is no ability to add custom headers to API requests.
Discussion: Benefits and Drawbacks
Custom headers are required for many deployments behind reverse proxies for additional authentication tokens or cookies. This only adds new compatibility and is fully backwards compatible.
Changes to the Documentation
Docstrings are updated
Proposed Release Note Entry
Add support for custom headers
Double Check
develbranch.