Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netbox 3.6 support (Sourcery refactored) #168

Merged
merged 1 commit into from
Oct 14, 2023
Merged

netbox 3.6 support (Sourcery refactored) #168

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions .devcontainer/configuration/configuration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
# Read secret from file
def _read_secret(secret_name: str, default: str | None = None) -> str | None:
try:
f = open('/run/secrets/' + secret_name, 'r', encoding='utf-8')
f = open(f'/run/secrets/{secret_name}', 'r', encoding='utf-8')
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function _read_secret refactored with the following changes:

except EnvironmentError:
return default
else:
Expand All @@ -33,13 +33,10 @@ def _read_secret(secret_name: str, default: str | None = None) -> str | None:
def _environ_get_and_map(variable_name: str, default: str | None = None, map_fn: Callable[[str], Any | None] = None) -> Any | None:
env_value = environ.get(variable_name, default)

if env_value == None:
if env_value is None:
return env_value

if not map_fn:
return env_value

return map_fn(env_value)
return env_value if not map_fn else map_fn(env_value)
Comment on lines -36 to +39
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function _environ_get_and_map refactored with the following changes:


_AS_BOOL = lambda value : value.lower() == 'true'
_AS_INT = lambda value : int(value)
Expand Down
Loading