Fixes: #14044 - Allow regex renaming of unnamed devices

[DanSheps]

Fixes: #14044 - Allow regex renaming of unnamed devices

• Allow regex renaming of unnamed devices (already allowed actually)
• Catch errors relating to unnamed devices or integrity errors as a result of the rename process

Note: I removed the ^$ requirement as, in my view, as long as there is a valid regex and the regex results in a unique set, we don't need to enforce the ^$ requirement. For example: ^ or .* or . would all be equally as valid.

The main changes here catch both IntegrityError's from the DB and a validation error to ensure regex is used.

[jeremystretch]

Might it be simpler to just replace original values of None with an empty string?

[jeremystretch]

Are these changes strictly relevant to #14044? If not, we should break them out into a separate bug report.

[DanSheps]

They are. This will throw a validation error if we don't use regex (We can easily dump that though if we want to go to None == '')

The Integrity error will catch any associated integrity errors. I tried to fine a way to separate the integrity error out and only capture an integrity error that relates to the name field but it wasn't easily do-able.

[github-actions]

This PR has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further action is taken.

[jeremystretch]

AFAICT the only change actually needed to address #14044 is to ensure that a null name is always treated as an empty string. (Currently this is true only when regex is enabled.) Have I missed something?

[DanSheps]

AFAICT the only change actually needed to address #14044 is to ensure that a null name is always treated as an empty string. (Currently this is true only when regex is enabled.) Have I missed something?

I can get that fixed up right away then

[github-actions]

This PR has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further action is taken.