Rot hs qb #12
Merged
Rot hs qb #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… operator test after returning from break.
… operator test after returning from break.
# Conflicts: # netket_fidelity/operator/singlequbit_gates.py
…ce to support both spin and qubit spaces. Implemented additional test.
-better naming convention -np.testing.assert_allclose instead of assert Addition -matrix element check.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
==========================================
+ Coverage 77.13% 77.23% +0.10%
==========================================
Files 21 21
Lines 678 681 +3
Branches 117 117
==========================================
+ Hits 523 526 +3
Misses 129 129
Partials 26 26 ☔ View full report in Codecov by Sentry. |
|
@Mboky perfect, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm sorry for the delay. I added feedback from @alleSini99.
kind regards,
Mohammed Boky