Fix BoringSSL artifact #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normanmaurer
force-pushed
the
boringssl_fix
branch
from
501b073
to
cb0e71d
Compare
normanmaurer
force-pushed
the
boringssl_fix
branch
2 times, most recently
from
c374727
to
754c47c
Compare
chrisvest
approved these changes
Oct 30, 2024
Motivation: We did end up with a BoringSSL artifact that could not load the native lib Modifications: - Correctly link - Add test that validates that the native lib can be loaded for BoringSSL Result: Correctly be able to use BoringSSL again
normanmaurer
force-pushed
the
boringssl_fix
branch
from
754c47c
to
0f97c04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We did end up with a BoringSSL artifact that could not load the native lib
Modifications:
-Add test that validates that the native lib can be loaded for BoringSSL
Result:
Correctly be able to use BoringSSL again