Added option to restore local vars during validation #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having load params dict act as a modifier rather than complete replac…
… remaps the specified subset
Updated tests to reflect that load_param_dict keeps all variables but…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially addresses issue #140 in that it fixes the issue I was having with tf metrics which keeps local variables for streaming confusion matrices, which were not being initialized during validation (test_from_params) mode. However, if there is a use case where the user wanted to restore the values of these local variables from the checkpoint (rather than from scratch, which is usually what you want -- e.g. you want to restore the confusion matrix to 0 whenever you re-evaluate a model), then this does not address that problem. However, it fixes the primary reason I made the issue in the first place.