Resolve CCA Incorrect Statistics #413 #419
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for hyppo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Thanks for the contribution. Do you have unit tests showing that this change is right? That would involve ensuring that the change is the same as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Closes CCA Incorrect Statistics #413
Type of change
Bug fix
What does this implement/fix?
Fixed bug in statistic method CCA implementation where it was incorrectly calculating the correlation statistic for 1-D data. Now, when the input only has one dimension, it uses Pearson's correlation instead of SVD.
Additional information
This was an assignment for a course to get familiar with open source. I'm sure I missed a lot with the development process, but hopefully this helps !(?)