Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipe ABC to enable mandatory input workspaces #468

Merged
merged 4 commits into from
Oct 9, 2024

Conversation

rboston628
Copy link
Contributor

@rboston628 rboston628 commented Oct 9, 2024

Description of work

This updates the Recipe ABC to have a set of mandatory input workspaces.

Explanation of work

The default validateInputs method on the Recipe ABC was setup to check for the existence of every workspace in the groceries dictionary, even if it is an output.

This specifies the set of mandatory inputs that must be in the groceries. The others can be Outputs or optional InOuts, or just optional workspaces.

This allows implementing recipes to use the default without needing to override.

To test

Dev testing

Make sure all unit tests pass.

Make sure manual testing can get to save.

CIS testing

Enabler, no need

Link to EWM item

This came up as part of work on

EWM#7388

Verification

N/A

Acceptance Criteria

N/A

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.30%. Comparing base (53daaa0) to head (bb7b182).
Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #468   +/-   ##
=======================================
  Coverage   96.29%   96.30%           
=======================================
  Files          61       61           
  Lines        4486     4498   +12     
=======================================
+ Hits         4320     4332   +12     
  Misses        166      166           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rboston628 rboston628 marked this pull request as ready for review October 9, 2024 19:03
@rboston628 rboston628 enabled auto-merge (squash) October 9, 2024 20:36
@rboston628 rboston628 merged commit f16f366 into next Oct 9, 2024
6 checks passed
@rboston628 rboston628 deleted the patch-mandatory-args branch October 9, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants