-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EWM7751 replaced save tab of reduction with pop up, removed some noisy warnings #482
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #482 +/- ##
=======================================
Coverage 96.53% 96.53%
=======================================
Files 63 63
Lines 4503 4503
=======================================
Hits 4347 4347
Misses 156 156 ☔ View full report in Codecov by Sentry. |
startLambda=None, | ||
iterateLambda=None, | ||
resetLambda=None, | ||
cancelLambda=None, | ||
parent=None, | ||
completionMessageLambda=lambda: Config["ui.default.workflow.completionMessage"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like I could reduce the number of lambdas by just passing the WorkflowImplementer itself.
dc2f1d5
to
eeffd7c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and reduction works as it should.
…y warnings (#482) * replaced save tab of reduction with pop up, removed some noisy warnings * add new config props to test yml * removed comment, updated completion text to use old informative blob * integration tests now expect workflows to finish with qmessagebox.information
Description of work
This exposes the workflow completion message to the
WorkflowBuilder
to enable an implemented workflow to display a custom message upon completion.This was then utilized to replace the Save step of the
ReductionWorkflow
(which does nothing) with a simple pop up that accomplishes the same goal: Informing the user that redcution has completed successfully.This turns off a particularly noisy in-actionable warning message too.
To test
Run Reduction with run number
59039
, observe that it completes.Ensure the reduction results are in the workspace list and are also persisted to disk.
Link to EWM item
EWM#7751
Verification
Acceptance Criteria
This list is for ease of reference, and does not replace reading the EWM story as part of the review. Verify this list matches the EWM story before reviewing.