EWM7751 replaced save tab of reduction with pop up, removed some noisy warnings #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #482 +/- ##
=======================================
Coverage 96.53% 96.53%
=======================================
Files 63 63
Lines 4503 4503
=======================================
Hits 4347 4347
Misses 156 156 ☔ View full report in Codecov by Sentry. |
walshmm
changed the title
walshmm
commented
Oct 24, 2024
Comment on lines
+10
to
+15
| startLambda=None, | ||
| iterateLambda=None, | ||
| resetLambda=None, | ||
| cancelLambda=None, | ||
| parent=None, | ||
| completionMessageLambda=lambda: Config["ui.default.workflow.completionMessage"], |
There was a problem hiding this comment.
I feel like I could reduce the number of lambdas by just passing the WorkflowImplementer itself.
walshmm
force-pushed
the
ewm7751_replace_reduction_save_view_w_popup
branch
from
dc2f1d5
to
eeffd7c
Compare
dlcaballero16
approved these changes
Oct 24, 2024
rboston628
pushed a commit
that referenced
this pull request
Oct 25, 2024
…y warnings (#482) * replaced save tab of reduction with pop up, removed some noisy warnings * add new config props to test yml * removed comment, updated completion text to use old informative blob * integration tests now expect workflows to finish with qmessagebox.information
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
This exposes the workflow completion message to the
WorkflowBuilderto enable an implemented workflow to display a custom message upon completion.This was then utilized to replace the Save step of the
ReductionWorkflow(which does nothing) with a simple pop up that accomplishes the same goal: Informing the user that redcution has completed successfully.This turns off a particularly noisy in-actionable warning message too.
To test
Run Reduction with run number
59039, observe that it completes.Ensure the reduction results are in the workspace list and are also persisted to disk.
Link to EWM item
EWM#7751
Verification
Acceptance Criteria
This list is for ease of reference, and does not replace reading the EWM story as part of the review. Verify this list matches the EWM story before reviewing.