Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename recipes now that approved #483

Merged
merged 4 commits into from
Oct 24, 2024
Merged

Rename recipes now that approved #483

merged 4 commits into from
Oct 24, 2024

Conversation

rboston628
Copy link
Contributor

@rboston628 rboston628 commented Oct 24, 2024

Description of work

The pixel and group segments of the diffcal process were migrated to recipes.

To make the review easier, they were changed in place without moving or renaming the files.

This will move the files.

Explanation of work

Absolutely nothing was changed, except moving and renaming files.

To test

Dev testing

Make sure all unit tests pass. There is no need to do further testing.

CIS testing

N/A

Link to EWM item

EWM#7388

Verification

  • the author has read the EWM story and acceptance critera
  • the reviewer has read the EWM story and acceptance criteria
  • the reviewer certifies the acceptance criteria below reflect the criteria in EWM

Acceptance Criteria

This list is for ease of reference, and does not replace reading the EWM story as part of the review. Verify this list matches the EWM story before reviewing.

This PR applies to ONLY these criteria

  • The algorithms PixelDiffractionCalibration and GroupDiffractionCalibration have been converted to Recipes deriving from the Recipe ABC
  • The existing algorithms PixelDiffractionCalibration and GroupDiffractionCalibration are removed

@rboston628 rboston628 marked this pull request as ready for review October 24, 2024 19:43
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.39%. Comparing base (5877271) to head (2f35420).
Report is 2 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next     #483      +/-   ##
==========================================
- Coverage   96.53%   96.39%   -0.14%     
==========================================
  Files          63       65       +2     
  Lines        4496     4740     +244     
==========================================
+ Hits         4340     4569     +229     
- Misses        156      171      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rboston628 rboston628 enabled auto-merge (squash) October 24, 2024 19:48
@rboston628 rboston628 merged commit 523b781 into next Oct 24, 2024
7 of 8 checks passed
@rboston628 rboston628 deleted the ewm7388-rename-recipe branch October 24, 2024 20:42
rboston628 added a commit that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants