Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependabot can't see secrets or upload codecov results #52

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

peterfpeterson
Copy link
Member

Since dependabot doesn't have access to secrets, skip uploading codecov results.

Long description of the changes:

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

References

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.15%. Comparing base (a8b2e66) to head (2ee2b2d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #52   +/-   ##
=======================================
  Coverage   77.15%   77.15%           
=======================================
  Files          16       16           
  Lines        1239     1239           
=======================================
  Hits          956      956           
  Misses        283      283           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@backmari backmari merged commit 8af626a into main Aug 21, 2024
5 checks passed
@backmari backmari deleted the optional_codecov branch August 21, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants