Connect to bees by IP instead of host names #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -253,10 +253,10 @@ def _attack(params): | |||
| pem_path = params.get('key_name') and _get_pem_path(params['key_name']) or None | |||
| if not os.path.isfile(pem_path): | |||
| client.load_system_host_keys() | |||
| client.connect(params['instance_name'], username=params['username']) | |||
| client.connect(params['instance_ip'], username=params['username']) | |||
There was a problem hiding this comment.
why would you not want the option to connect to both?
|
If this change is to be adopted, I think it should be accompanied by a command line option which enables "ssh by IP address". Because:
The option would probably allow for selection between "SSH by" name, IPv4 address, IPv6 address. |
|
I think that SSH by instance name is a bad idea. AWS allows to reconfigure internal VPC DNS through Route53. It is better to use IP addresses. PS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes hostnames are not resolved.