Merge pull request #933 from newscorp-ghfb/feat/930-extend-toNewsKitI…

…con-types-3 Feat/930 extend to news kit icon types 3
newscorp-ghfb · Jul 25, 2024 · 29ab537 · 29ab537
2 parents 93ca1c8 + 2d6736e
commit 29ab537
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -1,7 +1,7 @@
 version: 2.1
 
 orbs:
-  slack: circleci/slack@4.10.1
+  slack: circleci/slack@4.13.3
   aws-cli: circleci/[email protected]
   github-cli: circleci/[email protected]
   node: circleci/[email protected]
@@ -369,7 +369,7 @@ jobs:
           at: ~/project
       - run:
           name: Install make
-          command: apt-get update && apt-get install -y make
+          command: apt-get update && apt-get install -y make curl
       - run:
           name: install cypress
           command: make install_cypress

diff --git a/cypress/site/functional/accessibility.common.js b/cypress/site/functional/accessibility.common.js
@@ -16,8 +16,6 @@ export function runA11yTestForRoute(route) {
           rules: {
             'heading-order': {enabled: false},
             'color-contrast': {enabled: false},
-            'duplicate-id-aria': {enabled: false},
-            'duplicate-id-active': {enabled: false},
           },
         });
       } else if (
@@ -35,6 +33,9 @@ export function runA11yTestForRoute(route) {
         cy.checkA11y(null, {
           rules: {
             'color-contrast': {enabled: false},
+            'duplicate-id-aria': {enabled: false},
+            'duplicate-id-active': {enabled: false},
+            'duplicate-id': {enabled: false},
           },
         });
       }