-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(806) container queries and storybook #877
Open
LukeFinch
wants to merge
37
commits into
main
Choose a base branch
from
feat/806-container-queries-storybook
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+705
−190
Open
Changes from 19 commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
a162a43
feat(806): implement #400 container queries
LukeFinch 1608c53
feat(806): define queries on rules object
LukeFinch 98504da
feat(806): extend MQ to allow CQ rules
LukeFinch 53d1307
feat(806): wip
LukeFinch 1478cea
feat(806): update tests
LukeFinch 2341ccc
feat(806): handle responsive props container rules
LukeFinch 4d78efe
feat(806): typescript fixes
LukeFinch 8f1d77e
feat(806): fix types update test
LukeFinch d16da5a
fix(806): fix emotion package versions
LukeFinch 754c35c
feat(806): fix type for getAreasList
LukeFinch 6afb330
feat(806): merge main
LukeFinch c1ede9e
feat(806): change types for get typography from theme
LukeFinch e2f5585
feat(806): update examples, add block story
LukeFinch 99a49f3
Merge branch 'main' into feat/806-container-queries-storybook
LukeFinch 2a3befd
feat(806): update snapshots
LukeFinch d69a9f1
feat(806): update snapshots
LukeFinch 71aeceb
feat(806): address comments
LukeFinch 1507631
feat(806): test coverage
LukeFinch 3088f7c
Merge branch 'main' into feat/806-container-queries-storybook
LukeFinch 44b882f
feat(806): move container props to own function
LukeFinch 667e4dd
feat(806): move container props to own function
LukeFinch 4a1fcd6
feat(806): address comments
LukeFinch db0ddfe
feat(806): remove a test
LukeFinch a3becab
Merge branch 'main' into feat/806-container-queries-storybook
LukeFinch f316a46
feat(806): remove unused code
LukeFinch 80110a6
feat(806): move props out of overrides
LukeFinch b2425fb
feat(806): move props out of overrides
LukeFinch 43900b8
Merge branch 'main' into feat/806-container-queries-storybook
LukeFinch ba253fc
feat(806): test coverage, peer deps versions
LukeFinch 5c0e7b7
feat(806): container props tests
LukeFinch 04ad044
feat(806): merge main
LukeFinch 48cb5c5
feat(806): update package json snapshot
LukeFinch 49d001b
feat(806): fix merge conflicts
LukeFinch 3f5ca77
Merge branch 'main' into feat/806-container-queries-storybook
mutebg faedeb3
Merge branch 'main' into feat/806-container-queries-storybook
mutebg 8a1aff9
Merge branch 'main' into feat/806-container-queries-storybook
mutebg 3afbf60
Merge branch 'main' into feat/806-container-queries-storybook
mutebg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will these changes no longer work with lower versions of emotion? Do note that we have emotion versions specified in the
peerDependencies
for consumers and this will likely need to be upped.It's a bit grey to me if this would actually make this a breaking change or not. Given it's only a minor version bump on a dependency we could argue it isn't... but I guess there is still some level of risk for consumers who are upgrading.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It didn't work on the version we had, and required the bump. I'm not sure which specific minimum version it's in. I could narrow that down. But ultimately, it does require moving to a higher emotion version to use container queries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
11.10.4
will be the lowest supported version can we please update the peer dependencies?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also I think it should be sub 12 not the thin range that it's currently specified to