Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spike(891): add createFontFacesForTheme #892

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LukeFinch
Copy link
Contributor

closes #000

What

  1. Background - why this is needed
  2. What did you do
  3. What does the reviewers should expect

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@LukeFinch LukeFinch added the DO NOT MERGE Do not merge this PR label May 12, 2023
Comment on lines +130 to +132
type FontPaths = {
[key: string]: string;
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, in an ideal world we can export this directly from the publisher and createFontFacesForTheme to be part of the newskit-theme/title so that we can add the necessary types.

like type

type FontPaths = {
  'Poppins': string,
  'DM Mono': string,
};

that way we can guarantee the people provide all fonts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE Do not merge this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants