fix(pecl): configuration options in the right order #5373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @ernolf! It was my mistake, see our internal chat for the complete explanation. In order to merge this, we need to update this workflow so that the dependencies still get correctly updated: https://github.com/nextcloud/all-in-one/blob/main/.github/workflows/nextcloud-update.yml |
✔️ e5ef4a2 |
build(pecl): update sed commands in workflow script to handle module versions dynamically build(imagick): update url Signed-off-by: ernolf <[email protected]>
ernolf
force-pushed
the
ernolf/fix/pecl-install-invocation
branch
from
e5ef4a2
to
d7428f0
Compare
|
This is now released with v9.7.0 Beta. Testing and feedback is welcome! See https://github.com/nextcloud/all-in-one#how-to-switch-the-channel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses an issue with the PECL installation of the memcached and redis extensions.
The invocation did not properly pass the configuration options, which resulted in igbinary not being enabled for both memcached and redis.
old:
new:
