Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExApps management and Admin settings UI logic fixes #177

Merged
merged 5 commits into from
Dec 21, 2023
Merged

ExApps management and Admin settings UI logic fixes #177

merged 5 commits into from
Dec 21, 2023

Conversation

andrey18106
Copy link
Collaborator

@andrey18106 andrey18106 commented Dec 20, 2023 •
edited by bigcat88
Loading

Resolves: #171

Also fixes:

  • Update button in UI not working.

@andrey18106
ui fixes
7c4df8d 
Signed-off-by: Andrey Borysenko <[email protected]>
@bigcat88
Copy link
Member

image

Failed to enable ExApp message do not go away after successful enabling.

Steps to reproduce:

  1. Enable App that for example is turned off(or any other way to make Enabling failed)
  2. Again Enable App, but now make enabling process be successful.
  3. Message from Step1 does not go away, even if Step2 finish with success.

bigcat88
bigcat88 requested changes Dec 21, 2023
View reviewed changes
Copy link
Member

@bigcat88 bigcat88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And with this PR for some reason I cannot update an App from UI, pressing Update button, only disables ExApp and raises an error.

@bigcat88
Copy link
Member

And with this PR for some reason I cannot update an App from UI, pressing Update button, only disables ExApp and raises an error.

this was fixed by last commit to this PR.

bug was introduced in previous releases that added GPU support

@bigcat88 bigcat88 self-requested a review December 21, 2023 12:39
bigcat88
bigcat88 approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@bigcat88 bigcat88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now it is fine

@bigcat88 bigcat88 enabled auto-merge (squash) December 21, 2023 12:50
@bigcat88 bigcat88 merged commit 3e1e758 into main Dec 21, 2023
29 checks passed
@bigcat88 bigcat88 deleted the ui-fixes branch December 21, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigcat88 bigcat88 bigcat88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing "Uninstall" button for ExApp without refreshing page
2 participants
@andrey18106 @bigcat88