Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(AppApi): Advanced Deploy Options for ExApps #1510

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

bigcat88
Copy link
Member

This is the AppStore part of this AppAPI feature: nextcloud/app_api#406

This PR adds the ability to specify additional environment parameters, and the AppStore starts emitting information about this via an endpoint.

This is necessary because AppAPI at the stage of pressing the "Deploy and Install" button does not have the application info.xml file, and AppAPI cannot parse the information from there without downloading it - therefore we give it via the standard endpoint.

<environment-variables>
    <variable>
        <name>SOME_VALUE1</name>
        <display-name>Display name 1</display-name>
        <description>Some useful description of it</description>
    </variable>
    <variable>
        <name>SOME_VALUE2</name>
        <display-name>Display name 2</display-name>
        <description>Example of second variable with the 'default' value</description>
        <default>0</default>
    </variable>
</environment-variables>

@bigcat88 bigcat88 enabled auto-merge (squash) October 17, 2024 16:12
@bigcat88 bigcat88 merged commit 483b51e into master Oct 17, 2024
9 checks passed
@bigcat88 bigcat88 deleted the feat/appapi-deploy-env-vars branch October 17, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants