Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some feats, some fixes #7

Merged
merged 10 commits into from
Dec 15, 2023
Merged

Some feats, some fixes #7

merged 10 commits into from
Dec 15, 2023

Conversation

kyteinsky
Copy link
Contributor

No description provided.

@kyteinsky kyteinsky requested review from marcelklehr and julien-nc and removed request for julien-nc December 15, 2023 13:39
@kyteinsky
change CWYD to CC
294d0ca 
Signed-off-by: Anupam Kumar <[email protected]>
@marcelklehr
Copy link
Member

Can we also already adjust this https://github.com/nextcloud/context_chat/blob/main/lib/Service/LangRopeService.php#L44 + https://github.com/nextcloud/context_chat/blob/main/.github/workflows/integration-test.yml#L153?

marcelklehr
marcelklehr approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@marcelklehr marcelklehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure to fix the integration test, then we're good :)

@kyteinsky kyteinsky merged commit d9d9f15 into main Dec 15, 2023
20 checks passed
@delete-merged-branch delete-merged-branch bot deleted the changes branch December 15, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelklehr marcelklehr marcelklehr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyteinsky @marcelklehr