Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dev application name to keep a consitant migration behaviour for the dev and prod build #7683

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kaikli
Copy link

@kaikli kaikli commented Dec 18, 2024

keep application name and short name the same or different for the dev and prod build or some migration behaviour will work differently for each build

for example Application::setupConfigFile in src/gui/application.cpp:L519:

  • prod: $XDG_DATA_DIR/Nextcloud -> $XDG_CONFIG_DIR/Nextcloud
  • dev: $XDG_DATA_DIR/NextDev -> $XDG_CONFIG_DIR/Nextcloud

keep application name and short name the same for the dev and prod build or some migration logic will work differently for each build

Signed-off-by: kaikli <[email protected]>
@camilasan
Copy link
Member

@kaikli have you tested your changes in the 3 platforms?

@camilasan camilasan self-assigned this Dec 19, 2024
@camilasan camilasan modified the milestones: 3.16.0, 3.15.3 Dec 19, 2024
@kaikli
Copy link
Author

kaikli commented Dec 19, 2024

@kaikli have you tested your changes in the 3 platforms?

@camilasan Only for linux, but it should only change the display and folder names of the dev build.

Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not mind but having different names allowed us to easily undestand if it comes from APPLICATION_NAME or from APPLICATION_SHORTNAME
so why do you want to change that ?

@kaikli
Copy link
Author

kaikli commented Dec 20, 2024

I do not mind but having different names allowed us to easily undestand if it comes from APPLICATION_NAME or from APPLICATION_SHORTNAME so why do you want to change that ?

I found this while working on the PR #7665, because I could not reproduce the same behaviour with the dev build. Because the prod build migrates from $XDG_DATA_DIR/Nextcloud to $XDG_CONFIG_DIR/Nextcloud and then uses both of this folders. The dev build on the other side migrates from $XDG_DATA_DIR/NextDev to $XDG_CONFIG_DIR/Nextcloud and then uses $XDG_DATA_DIR/Nextcloud and $XDG_CONFIG_DIR/Nextcloud.

I actually would prefer to change the short application name for prod or use the long name for all folder names, but this would probably break something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants