Remove unecessary logic. #1213
Closed
Remove unecessary logic. #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SnowMB
reviewed
Aug 26, 2020
| @@ -86,10 +86,6 @@ if expr "$1" : "apache" 1>/dev/null || [ "$1" = "php-fpm" ] || [ "${NEXTCLOUD_UP | |||
|
|
|||
| if version_greater "$image_version" "$installed_version"; then | |||
| echo "Initializing nextcloud $image_version ..." | |||
| if [ "$installed_version" != "0.0.0.0" ]; then | |||
| echo "Upgrading nextcloud from $installed_version ..." | |||
There was a problem hiding this comment.
I would keep this line for the log.
|
I'll not be able to rebase at the moment :/ I hope I have sometime during the summer, I'd like to backport all the changes of our images here, but it seems complicated... Do you think it would be possible to have a call between maintainers of this image? I'd love to get this image stateless :) Have a nice weekend! |
J0WI
added a commit
to J0WI/docker-nextcloud
that referenced
this pull request
Jul 20, 2024
|
closing in favour of #2267 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did wrote this some years ago, when app update logic was not that great,
It is now resolved.