-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for DBINDEX redis config value in docker compose #2288
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Jan Zalar [email protected] Signed-off-by: janz <[email protected]>
#1286 (comment) this becomes a hassle especially, when one'd try to automate deployment. It feels like this would be a nice feature to have available if needed irregardless if it's not optimal for 90% of the cases. However! There is a middle ground imo - prefixes. This would work if you had a redis instance that's running for multiple services or even, if there are multiple NCs connecting to a redis cluster |
According to this: nextcloud/server#32203 the prefix for nextcloud is calculated, but then changes when either path, version and/or instanceid would change. If there was a way to make prefix optionally persistent, then these issues would be solved. |
Hi, maybe this helps as reference? |
Changing naming convetion to match others Signed-off-by: Jan Zalar <[email protected]>
Thank you for this, i changed it to configure session locking appropriately, aswell as name for env variable, to match the ones you used |
Currently, there is no support for adding dbindex config value ($CONFIG['redis']['dbindex']) within compose file. Even in manually updating or setting the value for a container, the changes aren't applied. This fixes the missing option.