Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: perform bulk message actions #10280

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Conversation

SebastianKrupinski
Copy link
Contributor

@SebastianKrupinski SebastianKrupinski commented Oct 22, 2024

Bulk mail message operations

Signed-off-by: SebastianKrupinski <[email protected]>
foreach ($accounts as $account) {
$account = new Account($account);
// determine if account belongs to the user and skip if not
if ($account->getUserId() != $userId) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to check, but please move this down into the db when looking up accounts. Make it a WHERE id IN (xxx) AND user_id = 'sebastian'. That avoids loaded any foreign accounts.

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far

@st3iny st3iny self-requested a review December 17, 2024 16:09
@SebastianKrupinski SebastianKrupinski marked this pull request as ready for review December 17, 2024 16:24
@SebastianKrupinski
Copy link
Contributor Author

Pslam complaints: will be dealt with, once the reviewed

@SebastianKrupinski
Copy link
Contributor Author

Merge: broke front end, reverting to draft

@SebastianKrupinski SebastianKrupinski marked this pull request as draft December 17, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🏗️ In progress
Development

Successfully merging this pull request may close these issues.

3 participants