-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use logical positioning instead of physical for bidirectional text support #47343
Conversation
Files potentially missing some code change from previous PR:
|
6583062
to
655d89b
Compare
Backend part moved to #47349 |
6e73d75
to
55dd692
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test seems to work fine, but some comments.
4527b31
to
b789d58
Compare
b789d58
to
c490fea
Compare
7ccea6d
to
7e6f6fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it, could not find any regressions with LTR language.
So I think we should be able to merge even before the backend PR which allows RTL layout.
7e6f6fd
to
3543ae0
Compare
Ready for review @susnux ? |
Yes I think so |
/compile amend-rebase / |
Signed-off-by: Mostafa Ahangarha <[email protected]>
Signed-off-by: Mostafa Ahangarha <[email protected]>
Signed-off-by: Mostafa Ahangarha <[email protected]>
Fix other background-positions Minor fix in link button icon position Update header left and right to start and end Signed-off-by: Mostafa Ahangarha <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
3543ae0
to
faeb2f0
Compare
Summary
This PR is the first step towards adding bidirectional text support to the Nextcloud ecosystem. It affects the entire project; accordingly, each app should have subsequent PRs.
The PR is 90+ percent complete. I decided to make the PR to
I had challenges in building the project. Generating
css
files and thedist
directory during development is something I am uncomfortable with.Because of supporting Samsung Internet, I needed to take some hacky approach.
Note:
We must update many components in NextCloud/vue. The most important one was the
header-menu
vue component which is already updated. Others will come soon. First, I need to ensure this PR is getting prepared for merge.Screenshots
TODO
.right
or.menu-left
.core/css/tooltip.scss
and its right|left classesdir
attribute on the body. (help needed)Checklist