[stable30] Transparent* database sharding #47561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot[bot]](https://avatars.githubusercontent.com/in/60201?s=60&v=4){kind=small}
artonge
force-pushed
the
backport/46639/stable30
branch
3 times, most recently
from
066d5fb
to
5b16734
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
artonge
force-pushed
the
backport/46639/stable30
branch
2 times, most recently
from
f1b08fb
to
1be67e9
Compare
artonge
approved these changes
Aug 28, 2024
sorbaugh
approved these changes
Aug 28, 2024
artonge
force-pushed
the
backport/46639/stable30
branch
from
1be67e9
to
dc374b4
Compare
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
…plicitly trusted Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]> [skip ci]
Signed-off-by: Louis Chemineau <[email protected]>
artonge
force-pushed
the
backport/46639/stable30
branch
from
dc374b4
to
140b36f
Compare
blizzz
reviewed
Aug 29, 2024
Comment on lines
+227
to
+232
| $connectionParams['sharding'] = $this->config->getValue('dbsharding', []); | ||
| $connectionParams['shard_connection_manager'] = $this->shardConnectionManager; | ||
| $connectionParams['auto_increment_handler'] = new AutoIncrementHandler( | ||
| $this->cacheFactory, | ||
| $this->shardConnectionManager, | ||
| ); |
There was a problem hiding this comment.
We unconditionally create an instance of 'AutoIncrementHandler' which dies on 32 bit already in its constructor, breaking 32bit.
Imo, line 228 and 229 should only be executed, if $connectionParams['sharding'] is not empty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #46639
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.