Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable30] Transparent* database sharding #47561

Merged
merged 19 commits into from
Aug 28, 2024
Merged

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Aug 28, 2024

Backport of #46639

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot added the 3. to review Waiting for reviews label Aug 28, 2024
@backportbot backportbot bot added this to the Nextcloud 30.0.1 milestone Aug 28, 2024
@artonge artonge force-pushed the backport/46639/stable30 branch 3 times, most recently from 066d5fb to 5b16734 Compare August 28, 2024 10:40
@artonge artonge force-pushed the backport/46639/stable30 branch 2 times, most recently from f1b08fb to 1be67e9 Compare August 28, 2024 12:19
@artonge artonge marked this pull request as ready for review August 28, 2024 12:20
Signed-off-by: Robin Appelman <[email protected]>
@sorbaugh sorbaugh merged commit f014c52 into stable30 Aug 28, 2024
173 of 174 checks passed
@sorbaugh sorbaugh deleted the backport/46639/stable30 branch August 28, 2024 15:23
@blizzz blizzz mentioned this pull request Aug 29, 2024
24 tasks
Comment on lines +227 to +232
$connectionParams['sharding'] = $this->config->getValue('dbsharding', []);
$connectionParams['shard_connection_manager'] = $this->shardConnectionManager;
$connectionParams['auto_increment_handler'] = new AutoIncrementHandler(
$this->cacheFactory,
$this->shardConnectionManager,
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We unconditionally create an instance of 'AutoIncrementHandler' which dies on 32 bit already in its constructor, breaking 32bit.

Imo, line 228 and 229 should only be executed, if $connectionParams['sharding'] is not empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants