fix: Properly handle share attributes if set to null #47638
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The database value of share attributes can be null, for example if creating a new share through the API. I stumbled over this when creating a new share with a deck card.
Now the frontend was unable to handle such a value from the backend and no advanced settings appeared at all, furthermore setting it was also not possible.
The default for canDownload is now always assumed true as this is the case if there is no share attribute set.
Checklist