-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable30] fix(settings): Hide forbidden UI elements for group managers #47651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
bug
3. to review
Waiting for reviews
backport-request
feature: user migration
Related to User migration
labels
Aug 30, 2024
/backport to stable29 |
Pytal
approved these changes
Aug 30, 2024
kesselb
approved these changes
Aug 31, 2024
susnux
added
4. to release
Ready to be released and/or waiting for tests to finish
and removed
3. to review
Waiting for reviews
labels
Aug 31, 2024
1. The "recent" accounts API only works for admin and delegated admin -> hide for group managers 2. Group managers can not create new groups -> Hide the UI to add a new group for them 3. Accounts created by group managers require one of the groups, which is managed by the group manager, assigned. So if the group manager only manageres a single group, we should preselect that group. Signed-off-by: Ferdinand Thiessen <[email protected]>
AndyScherzinger
force-pushed
the
backport/hidden-ui-group-manager
branch
from
September 2, 2024 09:12
25c0f0f
to
8c17f1e
Compare
/compile / |
Signed-off-by: nextcloud-command <[email protected]>
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/47651/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 8c17f1ea c77580f7
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/47651/stable29 Error: Failed to clone repository: Failed to checkout branches: Updating 1cc7851..7f0d0cf
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
4 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4. to release
Ready to be released and/or waiting for tests to finish
backport-request
bug
feature: user migration
Related to User migration
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist