fix(RichObjectStrings/Validator): Validate key value types of rich object parameters #47662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
requested review from
nickvergessen,
danxuliu,
a team,
icewind1991,
sorbaugh and
come-nc
and removed request for
a team
provokateurin
force-pushed
the
fix/notification/validate-rich-object-key-value-types
branch
from
5be384e
to
3f50f62
Compare
|
One non-breaking backportable alternative would be to just cast the keys and values automatically and only log a debug messages. That doesn't force everyone to immediately fix their apps and we could still make it throw an error later when hopefully everyone has seen the debug logs. |
3 tasks
nickvergessen
requested changes
Sep 2, 2024
provokateurin
force-pushed
the
fix/notification/validate-rich-object-key-value-types
branch
from
3f50f62
to
7264f5f
Compare
provokateurin
changed the title
|
Adjusted all the other uses of the validator to have the right types. |
come-nc
approved these changes
Sep 10, 2024
nickvergessen
approved these changes
Sep 10, 2024
…ject parameters Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
provokateurin
force-pushed
the
fix/notification/validate-rich-object-key-value-types
branch
from
ce94955
to
a3da745
Compare
provokateurin
deleted the
fix/notification/validate-rich-object-key-value-types
branch
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A lot of apps set invalid rich object parameters for notifications. Most common are integer ids were the casting was forgotten.
Technically this is not a breaking change since the apps triggering this behavior are just broken, but we are way to late into the cycle to backport this to 30 and have everyone fix their apps, so I'm not doing that (let alone backport it to older versions).
Not sure if this needs to have some upgrade docs, please let me know.
Checklist