Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(users): improve recently active search #48559

Merged
merged 3 commits into from
Oct 30, 2024
Merged

fix(users): improve recently active search #48559

merged 3 commits into from
Oct 30, 2024
+103 −33

Conversation

Altahrim
Copy link
Collaborator

@Altahrim Altahrim commented Oct 3, 2024 •
edited
Loading

Summary

  • Remove DISTINCT clause to fix PgSQL
  • Use data from users only if necessary (search)
  • Don't show people who never connected in active list
  • Add test
  • Add hard limit on list (100 users max)

TODO

  • badge still count all users instead of actives ones

Checklist

@Altahrim Altahrim self-assigned this Oct 3, 2024
@Altahrim Altahrim added bug 2. developing Work in progress labels Oct 3, 2024
@Altahrim
Copy link
Collaborator Author

Altahrim commented Oct 3, 2024

/backport to stable30

@Altahrim Altahrim requested review from a team, ArtificialOwl, artonge and come-nc and removed request for a team October 3, 2024 14:34
@Altahrim Altahrim marked this pull request as ready for review October 3, 2024 14:34
come-nc
come-nc approved these changes Oct 7, 2024
View reviewed changes
tests/lib/User/ManagerTest.php Outdated Show resolved Hide resolved
@Altahrim Altahrim force-pushed the fix/recently_active_pgsql branch 9 times, most recently from 3287967 to b0f7fe8 Compare October 16, 2024 09:54
@Altahrim Altahrim force-pushed the fix/recently_active_pgsql branch 2 times, most recently from 157fd45 to 22061d1 Compare October 17, 2024 07:37
@artonge artonge force-pushed the fix/recently_active_pgsql branch 4 times, most recently from 6f585ca to 9c11ec8 Compare October 24, 2024 16:51
@Altahrim Altahrim force-pushed the fix/recently_active_pgsql branch 7 times, most recently from c463a32 to cb83cef Compare October 29, 2024 16:39
@Altahrim
fix(users): use correct active user count
34ade09 
Signed-off-by: Benjamin Gaussorgues <[email protected]>
@Altahrim
fix(users): improve recently active search
79db082 
- Remove DISTINCT clause to fix PgSQL
- Join user table only if necessary
- Don't show people who never connected in active list
- Add test

Signed-off-by: Benjamin Gaussorgues <[email protected]>
@Altahrim
fix(sharding): typo in addOrderBy
49bd175 
Signed-off-by: Benjamin Gaussorgues <[email protected]>
@Altahrim Altahrim merged commit dac15d1 into master Oct 30, 2024
177 checks passed
@Altahrim Altahrim deleted the fix/recently_active_pgsql branch October 30, 2024 09:09
@backportbot backportbot bot mentioned this pull request Oct 30, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@artonge artonge Awaiting requested review from artonge

@come-nc come-nc Awaiting requested review from come-nc

Assignees

@Altahrim Altahrim

Labels
2. developing Work in progress bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: accounts -> recently active does not work on pgsql
3 participants
@Altahrim @artonge @come-nc