Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(systemtags): add bulk tagging action #48786

Merged
merged 12 commits into from
Oct 29, 2024
Merged

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Oct 18, 2024

Fix #45935

image

@skjnldsv skjnldsv added this to the Nextcloud 31 milestone Oct 18, 2024
@skjnldsv skjnldsv self-assigned this Oct 18, 2024
@skjnldsv skjnldsv force-pushed the feat/files-bulk-tagging branch 3 times, most recently from dc9cbf5 to 14b2817 Compare October 23, 2024 07:27
@skjnldsv skjnldsv force-pushed the feat/files-bulk-tagging branch 3 times, most recently from 02602f0 to f69c5be Compare October 26, 2024 07:06
@skjnldsv

This comment was marked as resolved.

@skjnldsv skjnldsv force-pushed the feat/files-bulk-tagging branch 3 times, most recently from 9a86741 to 1e8dddc Compare October 26, 2024 13:45
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 29, 2024
@skjnldsv skjnldsv marked this pull request as ready for review October 29, 2024 08:08
@skjnldsv skjnldsv requested review from susnux, provokateurin, a team, szaimen, sorbaugh and Fenn-CS and removed request for a team October 29, 2024 10:13
@szaimen szaimen removed their request for review October 29, 2024 10:15
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PHP looks good to me, just a minor suggestion

$table = $schema->getTable('systemtag');

if (!$table->hasColumn('etag')) {
$table->addColumn('etag', 'string', [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$table->addColumn('etag', 'string', [
$table->addColumn('etag', Types::STRING, [

@skjnldsv skjnldsv merged commit 73fdf2c into master Oct 29, 2024
179 checks passed
@skjnldsv skjnldsv deleted the feat/files-bulk-tagging branch October 29, 2024 10:20
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement feature: dav feature: files
Projects
Status: 🏗️ In progress
Development

Successfully merging this pull request may close these issues.

Add Bulk Tagging on new Files app [28+]
3 participants