-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(systemtags): add bulk tagging action #48786
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
added
enhancement
2. developing
Work in progress
feature: dav
feature: files
labels
Oct 18, 2024
skjnldsv
force-pushed
the
feat/files-bulk-tagging
branch
3 times, most recently
from
October 23, 2024 07:27
dc9cbf5
to
14b2817
Compare
skjnldsv
force-pushed
the
feat/files-bulk-tagging
branch
3 times, most recently
from
October 26, 2024 07:06
02602f0
to
f69c5be
Compare
This comment was marked as resolved.
This comment was marked as resolved.
nextcloud-command
force-pushed
the
feat/files-bulk-tagging
branch
from
October 26, 2024 07:16
f69c5be
to
e6bc4de
Compare
skjnldsv
force-pushed
the
feat/files-bulk-tagging
branch
3 times, most recently
from
October 26, 2024 13:45
9a86741
to
1e8dddc
Compare
skjnldsv
added
3. to review
Waiting for reviews
and removed
2. developing
Work in progress
labels
Oct 29, 2024
Signed-off-by: skjnldsv <[email protected]>
Signed-off-by: skjnldsv <[email protected]>
Signed-off-by: skjnldsv <[email protected]>
Signed-off-by: skjnldsv <[email protected]>
…nces Signed-off-by: skjnldsv <[email protected]>
Signed-off-by: skjnldsv <[email protected]>
Signed-off-by: skjnldsv <[email protected]>
Signed-off-by: skjnldsv <[email protected]>
Signed-off-by: skjnldsv <[email protected]>
Signed-off-by: skjnldsv <[email protected]>
Signed-off-by: skjnldsv <[email protected]>
Signed-off-by: skjnldsv <[email protected]>
skjnldsv
force-pushed
the
feat/files-bulk-tagging
branch
from
October 29, 2024 08:11
1e8dddc
to
3e6d18a
Compare
skjnldsv
requested review from
susnux,
provokateurin,
a team,
szaimen,
sorbaugh and
Fenn-CS
and removed request for
a team
October 29, 2024 10:13
provokateurin
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PHP looks good to me, just a minor suggestion
$table = $schema->getTable('systemtag'); | ||
|
||
if (!$table->hasColumn('etag')) { | ||
$table->addColumn('etag', 'string', [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
$table->addColumn('etag', 'string', [ | |
$table->addColumn('etag', Types::STRING, [ |
susnux
approved these changes
Oct 29, 2024
skjnldsv
added
4. to release
Ready to be released and/or waiting for tests to finish
and removed
3. to review
Waiting for reviews
labels
Oct 29, 2024
This was referenced Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4. to release
Ready to be released and/or waiting for tests to finish
enhancement
feature: dav
feature: files
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #45935