Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear pending two factor tokens also from configuration #48933

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Clear pending two factor tokens also from configuration #48933

wants to merge 2 commits into from

Commits on Oct 28, 2024

  1. fix: Clear pending two factor tokens also from configuration 

    Otherwise as the tokens were removed from the database but not from the
configuration the next time that the tokens were cleared the previous
tokens were still got from the configuration, and trying to remove them
again from the database ended in a DoesNotExistException being thrown.

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
    @danxuliu
    danxuliu committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    ddb2412 View commit details
    Browse the repository at this point in the history

  2. fix: Handle exception when clearing previously removed two factor tokens 

    If a token was already removed from the database but not from the
configuration clearing the tokens will try to remove it again from the
database, which caused a DoesNotExistException to be thrown.

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
    @danxuliu
    danxuliu committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    549d204 View commit details
    Browse the repository at this point in the history