-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(active users): add more active user statistics intervals and improve presentation #691
Conversation
bfbf606
to
fab97cb
Compare
This comment was marked as resolved.
This comment was marked as resolved.
b8ec66b
to
87c8d58
Compare
A nice improvement, btw. |
Just noticed this drops the 5 minute stat from the UI. Was that intentional? |
I made the choice to not have too many statistics displayed in the UI, and I think it made more sense between 5 minutes and one hour to keep the second one. |
Thank you, nice enhancement 👍 |
87c8d58
to
1e87ff7
Compare
Changed to this. |
1e87ff7
to
aad51fe
Compare
…rove presentation Signed-off-by: Thomas Citharel <[email protected]>
aad51fe
to
0342a3c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, looks really good!
Separate issue probably, but the icon of the heading is misaligned?
/backport to stable30 |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Adds:
to the API endpoint.
This view will certainly get converted to Vue at some point (and with proper CSS variables), but it felt like a nice improvement (and to use the new metrics).
Before
After
Full width
Tablet
Large Mobile
Small Mobile