fix(archive): Improve archive preference handling #13404
Conversation
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
added
3. to review
bug
feature: api 🛠️
|
/backport to stable30 |
|
|
||
| $room = $participant->getRoom(); | ||
| if ($room->getType() === Room::TYPE_PUBLIC || $room->getType() === Room::TYPE_GROUP) { | ||
| // Turn of call notifications by default |
There was a problem hiding this comment.
| // Turn of call notifications by default | |
| // Turn off call notifications by default |
| if ($attendee->getNotificationLevel() === Participant::NOTIFY_DEFAULT | ||
| && $this->getDefaultGroupNotification() !== Participant::NOTIFY_NEVER) { | ||
| $attendee->setNotificationCalls(Participant::NOTIFY_MENTION); | ||
| } |
There was a problem hiding this comment.
Why do we need to consider the default group notification level? I thought it's relevant only when creating a new conversation.
Also, I think user expects to turn off all notifications automatically (maybe except mention) when archiving a conversation. They could have set "always" for group conversation previously and when archiving, they expect it to be changed to "only mention" and not stay "always" (why would they archive it then).
There was a problem hiding this comment.
I assume DEFAULT is stored in DB per each attendee, unless was redefined by that attendee. Then it makes sense to redefine default behaviour only
If they are annoyed by notifications, maybe they shouldn't have set it to ALWAYS?)
There was a problem hiding this comment.
I assume DEFAULT is stored in DB per each attendee, unless was redefined by that attendee. Then it makes sense to redefine default behaviour only
Even if it was redefined by attendee, it doesn't mean it should be applied in archive (the point of archive it to put the notifications frequency to the lowest (not in sidebar list, no call, no message notif).
If they are annoyed by notifications, maybe they shouldn't have set it to ALWAYS?)
Conversation was previously important (a deal) and now it's not (deal closed for a while now). A user can see archiving as a good shortcut to reduce the notifications at once.
🛠️ API Checklist
🏁 Checklist
docs/has been updated or is not required