Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(devices): add an option to always disable streams by default befo… #13484

Merged
merged 2 commits into from
Oct 11, 2024
Merged

feat(devices): add an option to always disable streams by default befo… #13484

merged 2 commits into from
Oct 11, 2024

Conversation

DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Oct 7, 2024 •
edited
Loading

…re joining the call

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
. image
Recording.2024-10-08.143834.mp4

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@DorraJaouad DorraJaouad added this to the 🌠 Next Minor (30.1) milestone Oct 7, 2024
@DorraJaouad DorraJaouad self-assigned this Oct 7, 2024
@DorraJaouad DorraJaouad changed the title feat(devices): add an option to always disable steams by default befo… feat(devices): add an option to always disable streams by default befo… Oct 7, 2024
@DorraJaouad DorraJaouad marked this pull request as ready for review October 7, 2024 09:06
@nickvergessen
Copy link
Member

I think this should be on a higher level.
Either it needs to be a user setting globally for all their rooms with an admin configurable default, or even a system wide setting.

@nickvergessen nickvergessen mentioned this pull request Oct 7, 2024
Closed
2 tasks
@DorraJaouad DorraJaouad force-pushed the feat/13446/disable-streams-by-default branch from 7f13da2 to 7335048 Compare October 8, 2024 12:33
Antreesy
Antreesy reviewed Oct 8, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works correctly. Left some comments to discuss:

src/components/CallView/shared/LocalAudioControlButton.vue Outdated Show resolved Hide resolved
src/components/SettingsDialog/SettingsDialog.vue Outdated Show resolved Hide resolved
src/stores/settings.js Outdated Show resolved Hide resolved
@DorraJaouad DorraJaouad force-pushed the feat/13446/disable-streams-by-default branch 3 times, most recently from 0a45483 to e1e1c8a Compare October 10, 2024 17:08
Antreesy
Antreesy approved these changes Oct 11, 2024
View reviewed changes
src/components/CallView/shared/LocalVideoControlButton.vue Outdated Show resolved Hide resolved
src/components/CallView/shared/LocalAudioControlButton.vue Outdated Show resolved Hide resolved
src/stores/settings.js Outdated Show resolved Hide resolved
@DorraJaouad DorraJaouad force-pushed the feat/13446/disable-streams-by-default branch from e1e1c8a to 8c6d2f0 Compare October 11, 2024 16:05
@DorraJaouad DorraJaouad merged commit f18fe92 into main Oct 11, 2024
46 checks passed
@DorraJaouad DorraJaouad deleted the feat/13446/disable-streams-by-default branch October 11, 2024 17:11
@DorraJaouad
Copy link
Contributor Author

/backport to stable30

@backportbot backportbot bot mentioned this pull request Oct 14, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@Antreesy Antreesy Antreesy approved these changes

Assignees

@DorraJaouad DorraJaouad

Labels
enhancement feature: call 📹 Voice and video calls feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
🌠 Next Minor (30)
Development

Successfully merging this pull request may close these issues.

Add option for camera and mic to be disabled by default
3 participants
@DorraJaouad @nickvergessen @Antreesy