-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(devices): add an option to always disable streams by default befo… #13484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DorraJaouad
added
enhancement
feature: frontend 🖌️
"Web UI" client
feature: call 📹
Voice and video calls
labels
Oct 7, 2024
DorraJaouad
changed the title
feat(devices): add an option to always disable steams by default befo…
feat(devices): add an option to always disable streams by default befo…
Oct 7, 2024
I think this should be on a higher level. |
2 tasks
DorraJaouad
force-pushed
the
feat/13446/disable-streams-by-default
branch
from
October 8, 2024 12:33
7f13da2
to
7335048
Compare
Antreesy
reviewed
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, works correctly. Left some comments to discuss:
Antreesy
reviewed
Oct 9, 2024
DorraJaouad
force-pushed
the
feat/13446/disable-streams-by-default
branch
3 times, most recently
from
October 10, 2024 17:08
0a45483
to
e1e1c8a
Compare
Antreesy
approved these changes
Oct 11, 2024
…ore joining the call Signed-off-by: DorraJaouad <[email protected]>
Signed-off-by: DorraJaouad <[email protected]>
DorraJaouad
force-pushed
the
feat/13446/disable-streams-by-default
branch
from
October 11, 2024 16:05
e1e1c8a
to
8c6d2f0
Compare
Antreesy
approved these changes
Oct 11, 2024
/backport to stable30 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…re joining the call
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
Recording.2024-10-08.143834.mp4
🏁 Checklist