Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: respect mimetype aliases for file previews #13504

Merged
merged 1 commit into from
Oct 15, 2024
Merged

fix: respect mimetype aliases for file previews #13504

merged 1 commit into from
Oct 15, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Oct 9, 2024 •
edited
Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
2024-10-09_19h02_50 2024-10-09_19h03_40

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added this to the 🖤 Next Major (31) milestone Oct 9, 2024
@Antreesy Antreesy requested a review from ShGKme October 9, 2024 17:05
@Antreesy Antreesy self-assigned this Oct 9, 2024
@nickvergessen
Copy link
Member

nickvergessen commented Oct 9, 2024 •
edited
Loading

Shouldn't the aliasing happen on the backend?
I mean it should actually never return something on the filesystem api that is not the "final one"?
https://github.com/nextcloud/server/blob/43b1fd7bb8540181284659def6e01b8854a10fc0/lib/private/Files/Type/Detection.php#L24

Or from which to which value are you translating?

@Antreesy
Copy link
Contributor Author

Antreesy commented Oct 9, 2024

That one was marked as 'video/x-matroska' aliased to 'video/webm'

@ShGKme
Copy link
Contributor

ShGKme commented Oct 15, 2024

Talk Desktop support is coming

@nickvergessen nickvergessen merged commit 7759320 into main Oct 15, 2024
46 checks passed
@nickvergessen nickvergessen deleted the fix/noid/mimes-aliases branch October 15, 2024 14:05
@Antreesy Antreesy mentioned this pull request Oct 15, 2024
Merged
@Antreesy
Copy link
Contributor Author

/backport to stable30

@backportbot backportbot bot mentioned this pull request Oct 17, 2024
Merged
@nickvergessen
Copy link
Member

/backport to stable30.0

@backportbot backportbot bot mentioned this pull request Oct 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@ShGKme ShGKme ShGKme approved these changes

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

Assignees

@Antreesy Antreesy

Labels
3. to review bug feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
🖤 Next Major (31)
Development

Successfully merging this pull request may close these issues.
3 participants
@Antreesy @nickvergessen @ShGKme