-
-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video calls using HPB shows no video from android app to android app #3358
Comments
I can confirm this. |
I can also confirm this |
Is this fixed with 18.0.0-rc1? If not, am I in the wrong movie? :) |
May be most users are not impacted by this problem or may be most users do not use HPB. I don't know. |
I can confirm this |
Will this issue be addressed in the next version ? or in some future version ? |
I can confrm, 18.0.1 |
Tested versions: |
I've been trying to find some clues in the signaling log and found nothing of interest. |
Another detail about this issue. I have experimented from time to time that in some video calls, one peer can see the other at the beginning, so only one side has to cycle the camera to make it appear on the other end. |
Tested it yesterday, can confirm the bug. HPB with android <-> android the video does not show up |
This issue is here with us for idk more than two years at this point?! Can't the devs just implement a script, too auto toggle the cameraas on the android app when a call started, just as a work around? Please |
I tried to look into this issue, it seems to be a twofold issue. Overwriting video state (problem on receiving side)It seem the following is happening
I am not totally sure where this race condition comes from or wether it's expected. A simple fix would be to just checking state diff --git a/app/src/main/java/com/nextcloud/talk/call/CallParticipant.java b/app/src/main/java/com/nextcloud/talk/call/CallParticipant.java
index 50c1ae669..3f9f83ed2 100644
--- a/app/src/main/java/com/nextcloud/talk/call/CallParticipant.java
+++ b/app/src/main/java/com/nextcloud/talk/call/CallParticipant.java
@@ -171,8 +171,7 @@ public class CallParticipant {
private void handleIceConnectionStateChange(PeerConnection.IceConnectionState iceConnectionState) {
callParticipantModel.setIceConnectionState(iceConnectionState);
- if (iceConnectionState == PeerConnection.IceConnectionState.NEW ||
- iceConnectionState == PeerConnection.IceConnectionState.CHECKING) {
+ if (iceConnectionState == PeerConnection.IceConnectionState.NEW) {
callParticipantModel.setAudioAvailable(null);
callParticipantModel.setVideoAvailable(null);
} Not sending initial media state (problem on sending side)The problem above would not be an issue, if talk-android would correctly send the initial media state. talk-android/app/src/main/java/com/nextcloud/talk/webrtc/PeerConnectionWrapper.java Lines 301 to 315 in 45b18a7
This will basically do nothing when using an HPB, because the wrapper of the participant does not have a |
Another support for my users would be if I could set on server side that at the beginning of a video call the camera is initially disabled and needs to be enabled. Is this possible? |
I can also confirm this on mine too. |
Don't know what is the problem with this issue. It's two years old. |
This issue is being worked on and a fix should be available soon |
@mahibi |
It is a priority, but it is also very complex thus it takes time. A colleague is working on this and it's hopefully available in the next weeks |
Steps to reproduce
Expected behaviour
The call is established and both users starts to see and hear to each other.
Actual behaviour
The call establishes and both users starts to hear each other but can't see the others video.
Device brand and model
Tested on various smart phone models with Android using Talk GPlay version and Lineage using Talk F-Droid version.
Nextcloud Talk app version
Tested with various versions. The problem has persisted since version 15 or so.
Nextcloud server version
Tested with various versions. It has happened since version 25 or so.
Talk version
Tested with various versions. It has happened since version 15 or so.
Custom Signaling server configured
Yes (specify version in Additional Information)
Custom TURN server configured
Yes
Custom STUN server configured
Yes
Android logs
No response
Server log
Nothing on the server log that day
Additional information
This problem has been happening through various Signaling versions. I think I first saw this with Signaling v1.1.0.
Also have been experimenting this using many different versions of Janus and is actually happening with the new 1.x branch that recently was made compatible with Talk.
Other observed details:
The text was updated successfully, but these errors were encountered: