Added a ProgressBar to display while uploading Pics/Files #3443

Smarshal21 · 2023-11-14T14:16:13Z

Resolves #2500

Overview

This pull request introduces a ProgressBar to enhance the user experience during file uploads. The ProgressBar provides visual feedback on the upload progress, making it more intuitive for users.

Changes Made:

Upload Functionality:

Modified the upload function to handle ProgressBar visibility.
The ProgressBar is set to VISIBLE during the upload process and GONE when the upload is complete.

WorkManager Integration:

Utilized WorkManager for managing the background file upload task.
Enqueued unique work to ensure proper handling of the upload task.

Observing WorkManager State:

Implemented an observer for the WorkManager to track the state of the file upload.
The ProgressBar is hidden once the upload is completed, and appropriate notifications are displayed.

🏁 Checklist

⛑️ Tests (unit and/or integration) are included or not needed
🔖 Capability is checked or not needed
🔙 Backport requests are created or not needed: /backport to stable-xx.x
📅 Milestone is set
🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

mahibi

I like the callback approach, however i think the solution is not yet fully developed.

I agree that we need to show the loading progress in the chat, but we should introduce placeholder messages for that, which is a bit more work.

With the current solution, the loading bar now floats above all messages which is a bit irritating, especially when uploads take longer. It is not obvious that it is the upload progress but it feels more like there are problems loading the chat.

rapterjet2004 · 2023-11-17T13:40:24Z

Placeholder messages seem to be necessary for this one. There should be a shimmer effect in place while the file is loading. We're already using this loading library in some of our xml.

We could have it so that when the file message is sent, a temporary placeholder message is added to the chat list, before being removed when the file message arrives from the server.

This also allows us a bit of freedom when it comes to design. We could implement a custom Nextcloud themed loading animation in the future, if we ever need to.

Smarshal21 · 2024-02-13T16:23:23Z

Placeholder messages seem to be necessary for this one. There should be a shimmer effect in place while the file is loading. We're already using this loading library in some of our xml.

We could have it so that when the file message is sent, a temporary placeholder message is added to the chat list, before being removed when the file message arrives from the server.

This also allows us a bit of freedom when it comes to design. We could implement a custom Nextcloud themed loading animation in the future, if we ever need to.

what would be better @mahibi @rapterjet2004 ? use the existing shimmer which appears while loading the chat or a custom shimmer for uploading ?

mahibi · 2024-03-05T13:02:32Z

Placeholder messages seem to be necessary for this one. There should be a shimmer effect in place while the file is loading. We're already using this loading library in some of our xml.
We could have it so that when the file message is sent, a temporary placeholder message is added to the chat list, before being removed when the file message arrives from the server.
This also allows us a bit of freedom when it comes to design. We could implement a custom Nextcloud themed loading animation in the future, if we ever need to.

what would be better @mahibi @rapterjet2004 ? use the existing shimmer which appears while loading the chat or a custom shimmer for uploading ?

i would say a loading circle (spinner) inside a placeholder message.

Fyi i rebased on master and fixed minor merge conflicts

rapterjet2004 · 2024-03-05T15:13:18Z

app/src/main/java/com/nextcloud/talk/chat/ChatActivity.kt

                fileUri,
                room,
                currentConversation?.displayName!!,
                metaData
-            )
+            ) { showProgressBar: Boolean ->
+                binding.idprogressbar.visibility = if (showProgressBar) View.VISIBLE else View.GONE


Suggested change

binding.idprogressbar.visibility = if (showProgressBar) View.VISIBLE else View.GONE

binding.idprogressbar.visibility = if (showProgressBar) View.VISIBLE else {

chatViewModel.refreshChatParams(

setupFieldsForPullChatMessages(

true,

globalLastKnownFutureMessageId,

true

)

)

View.GONE

}

Breaks with the recent refactoring of ChatActivity. Insert this line to fix it, so that uploaded files show up after sending.

Signed-off-by: Smarshal21 <[email protected]> Added ProgressBar Signed-off-by: Smarshal21 <[email protected]> Added ProgressBar Signed-off-by: Smarshal21 <[email protected]> added progress bar Signed-off-by: Smarshal21 <[email protected]>

Signed-off-by: Smarshal21 <[email protected]>

just rebased to origin/master and fixed some conflicts. Did not test or improve anything. Signed-off-by: Marcel Hibbe <[email protected]>

github-actions · 2024-03-29T20:25:23Z

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3443-talk.apk

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

github-actions · 2024-03-29T20:25:25Z

Codacy

Lint

Type	master	PR
Warnings	81	81
Errors	10	10

SpotBugs

Category	Base	New
Bad practice	6	6
Correctness	8	8
Dodgy code	110	110
Internationalization	3	3
Malicious code vulnerability	3	3
Performance	6	6
Security	1	1
Total	137	137

github-actions · 2024-03-31T02:03:43Z

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Smarshal21 requested review from AndyScherzinger and rapterjet2004 November 14, 2023 14:16

Smarshal21 mentioned this pull request Nov 14, 2023

Add a placeholder/progress bar for uploading pics/files #2500

Open

AndyScherzinger requested review from mahibi and removed request for AndyScherzinger November 15, 2023 11:45

AndyScherzinger added the 3. to review Waiting for reviews label Nov 15, 2023

Smarshal21 self-assigned this Nov 15, 2023

mahibi requested changes Nov 17, 2023

View reviewed changes

mahibi force-pushed the ProgressBar branch from 009be9e to d543a7b Compare March 5, 2024 12:57

rapterjet2004 requested changes Mar 5, 2024

View reviewed changes

AndyScherzinger force-pushed the ProgressBar branch from d543a7b to fc5e43a Compare March 29, 2024 15:10

Smarshal21 and others added 3 commits March 29, 2024 21:18

Added ProgressBar

73185da

Signed-off-by: Smarshal21 <[email protected]> Added ProgressBar Signed-off-by: Smarshal21 <[email protected]> Added ProgressBar Signed-off-by: Smarshal21 <[email protected]> added progress bar Signed-off-by: Smarshal21 <[email protected]>

Fixed ktlintCheck

a4b1a26

Signed-off-by: Smarshal21 <[email protected]>

fixes after rebase to origin/master

aa6a42b

just rebased to origin/master and fixed some conflicts. Did not test or improve anything. Signed-off-by: Marcel Hibbe <[email protected]>

AndyScherzinger force-pushed the ProgressBar branch from fc5e43a to aa6a42b Compare March 29, 2024 20:18

github-actions bot added the feedback-requested label Mar 31, 2024

woolfg mentioned this pull request Aug 7, 2024

show uploading files in conversation #2375

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added a ProgressBar to display while uploading Pics/Files #3443

Added a ProgressBar to display while uploading Pics/Files #3443

Smarshal21 commented Nov 14, 2023 •

edited by AndyScherzinger

Loading

mahibi left a comment

rapterjet2004 commented Nov 17, 2023

Smarshal21 commented Feb 13, 2024

mahibi commented Mar 5, 2024

rapterjet2004 Mar 5, 2024

github-actions bot commented Mar 29, 2024

github-actions bot commented Mar 29, 2024

github-actions bot commented Mar 31, 2024

-                binding.idprogressbar.visibility = if (showProgressBar) View.VISIBLE else View.GONE
+                binding.idprogressbar.visibility = if (showProgressBar) View.VISIBLE else {
+                    chatViewModel.refreshChatParams(
+                        setupFieldsForPullChatMessages(
+                            true,
+                            globalLastKnownFutureMessageId,
+                            true
+                        )
+                    )
+                    View.GONE
+                }

Added a ProgressBar to display while uploading Pics/Files #3443

Are you sure you want to change the base?

Added a ProgressBar to display while uploading Pics/Files #3443

Conversation

Smarshal21 commented Nov 14, 2023 • edited by AndyScherzinger Loading

Overview

Changes Made:

Upload Functionality:

WorkManager Integration:

Observing WorkManager State:

🏁 Checklist

mahibi left a comment

Choose a reason for hiding this comment

rapterjet2004 commented Nov 17, 2023

Smarshal21 commented Feb 13, 2024

mahibi commented Mar 5, 2024

rapterjet2004 Mar 5, 2024

Choose a reason for hiding this comment

github-actions bot commented Mar 29, 2024

github-actions bot commented Mar 29, 2024

Codacy

Lint

SpotBugs

github-actions bot commented Mar 31, 2024

Smarshal21 commented Nov 14, 2023 •

edited by AndyScherzinger

Loading