Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing contrast for the filter conversation dialog #4087

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

rapterjet2004
Copy link
Contributor

@rapterjet2004 rapterjet2004 commented Aug 16, 2024

Just copy-pasted the code from commons and tweaked the text color to be onSecondaryContainer

🖼️ Screenshots

🏚️ Before 🏡 After
Screenshot 2024-08-16 at 9 31 25 AM
image Screenshot 2024-08-16 at 9 33 57 AM

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

Signed-off-by: rapterjet2004 <[email protected]>
@rapterjet2004
Copy link
Contributor Author

/backport to stable-20.0

Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings8686
Errors132131

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1111
Dodgy code7878
Internationalization33
Malicious code vulnerability33
Performance66
Security11
Total108108

@sowjanyakch sowjanyakch merged commit e06f2e3 into master Aug 21, 2024
2 of 3 checks passed
@sowjanyakch sowjanyakch deleted the issue-4075-filter-conversation-constrast branch August 21, 2024 14:58
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4087-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter Conversation options are hard to read.
2 participants