Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/4378/add temporary messages while sending #4422

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

Feature/4378/add temporary messages while sending #4422

wants to merge 12 commits into from

Conversation

mahibi
Copy link
Collaborator

@mahibi mahibi commented Nov 6, 2024 •
edited
Loading

resolve #4378

WIP

🖼️ Screenshots

🏚️ Before 🏡 After
B A

🚧 TODO

  • recycler view problem
  • implement resend logic
  • with very slow internet connection, it happened that same message is sent twice (so with different reference id). Check how this can be avoided.
  • change implementation of temporary messages in offline mode (dataStore -> Room)
  • change usage of TemporaryMessageViewHolder (use for sending failed messages and "no-internet-connection" mode)
  • check "Unread messages" bug

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@mahibi mahibi mentioned this pull request Nov 18, 2024
Closed
6 tasks
@mahibi mahibi force-pushed the feature/4378/addTemporaryMessagesWhileSending branch from d335f4f to 17995ee Compare November 21, 2024 21:45
@mahibi mahibi force-pushed the feature/4378/addTemporaryMessagesWhileSending branch 4 times, most recently from 43335b2 to 85aeab0 Compare December 4, 2024 14:47
@mahibi mahibi force-pushed the feature/4378/addTemporaryMessagesWhileSending branch 3 times, most recently from 12eb375 to a255b91 Compare December 11, 2024 14:29
@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4422-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

mahibi added 10 commits December 13, 2024 13:51
@mahibi
add referenceId for "normal" sending of chat message
76448e8 
Signed-off-by: Marcel Hibbe <[email protected]>
@mahibi
use repository in MessageInputViewModel instead datasource
2e591db 
(as datasources should be only used in repositories)

use coroutines instead RxJava for api calls triggered by MessageInputViewModel

Signed-off-by: Marcel Hibbe <[email protected]>
@mahibi
fixes after some wrong merge after merge conflict
de405d5 
Signed-off-by: Marcel Hibbe <[email protected]>
@mahibi
WIP add temporary message
f108dd1 
Signed-off-by: Marcel Hibbe <[email protected]>
@mahibi
temp message is added (values are still wrong)
8fbf70e 
Signed-off-by: Marcel Hibbe <[email protected]>
@mahibi
WIP temp messages are replaced when same refId received from sever
aff7845 
Signed-off-by: Marcel Hibbe <[email protected]>
@mahibi
update temp messages also for initial pull of messages
1efc219 
Signed-off-by: Marcel Hibbe <[email protected]>
@mahibi
show x when sending failed
197e6f0 
Signed-off-by: Marcel Hibbe <[email protected]>
@mahibi
works okay (no resend logic yet, offline message mode not reworked)
807c934 
Signed-off-by: Marcel Hibbe <[email protected]>
@mahibi
prepare to replace no-internet-connection message handling (sorry Jul…
14caa73 
…ius!!)

Signed-off-by: Marcel Hibbe <[email protected]>
@mahibi mahibi force-pushed the feature/4378/addTemporaryMessagesWhileSending branch from 3356718 to 14caa73 Compare December 13, 2024 12:51
@github-actions GitHub Actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings158156
Errors7272

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1616
Dodgy code7171
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total104104

@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4422-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@mahibi
replace CharSequence with String for sendChatMessage
b4d86e0 
Signed-off-by: Marcel Hibbe <[email protected]>
@mahibi
WIP add options to temp messages
4fcc62c 
TODO:
check id type --> see TODO "currentTimeMillies fails as id because later on in the model it's not Long but Int!!!!" in OfflineFirstChatRepository.kt

Signed-off-by: Marcel Hibbe <[email protected]>
@mahibi mahibi force-pushed the feature/4378/addTemporaryMessagesWhileSending branch from 8aad686 to 4fcc62c Compare December 20, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show pending indicator for messages that are being sent (incl retry)
1 participant
@mahibi