chore: Improve release steps #711
Open
+49
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
commented
Jul 12, 2024
| git push origin v$(version) | ||
| git push releases v$(version) | ||
| ``` | ||
| 8. **Draft a new release** on GitHub in [nextcloud-releases/talk-desktop](https://github.com/nextcloud-releases/talk-desktop/releases) |
There was a problem hiding this comment.
This actually needs to be done on nextcloud/ otherwise there is an error/warning that no PRs can be found for the commits.
There was a problem hiding this comment.
You can draft the release for a not pushed version. Or I didn't understand your comment.
ShGKme
reviewed
Oct 25, 2024
| git push releases v$(version) | ||
| ``` | ||
| 7. **Draft a new release** on GitHub in [nextcloud-releases/talk-desktop](https://github.com/nextcloud-releases/talk-desktop/releases) | ||
| Built-in Talk in binaries is updated to $(talkVersion) Talk changelog: https://github.com/nextcloud/spreed/blob/$(talkVersion)/CHANGELOG.md |
There was a problem hiding this comment.
Suggested change
| Built-in Talk in binaries is updated to $(talkVersion) Talk changelog: https://github.com/nextcloud/spreed/blob/$(talkVersion)/CHANGELOG.md | |
| Built-in Talk in binaries is updated to Talk v$(talkVersion) |
| Built-in Talk in binaries is updated to $(talkVersion) Talk changelog: https://github.com/nextcloud/spreed/blob/$(talkVersion)/CHANGELOG.md | ||
| ``` | ||
| 3. Commit `CHANGELOG.md` | ||
| 4. Update version in `package.json` and `package-locked.json` using npm: |
There was a problem hiding this comment.
Suggested change
| 4. Update version in `package.json` and `package-locked.json` using npm: | |
| 4. Update version in `package.json` and `package-lock.json` using npm: |
| ```sh | ||
| npm version patch --no-git-tag | ||
| ``` | ||
| 3. Commit `package.json` and `package-locked.json` |
There was a problem hiding this comment.
Suggested change
| 3. Commit `package.json` and `package-locked.json` | |
| 3. Commit `package.json` and `package-lock.json` |
| git push origin v$(version) | ||
| git push releases v$(version) | ||
| ``` | ||
| 8. **Draft a new release** on GitHub in [nextcloud-releases/talk-desktop](https://github.com/nextcloud-releases/talk-desktop/releases) |
There was a problem hiding this comment.
You can draft the release for a not pushed version. Or I didn't understand your comment.
Comment on lines
+173
to
+179
| ```md | ||
| ## What's Changed | ||
|
|
||
| <details> | ||
| <!-- Generated content --> | ||
| </details> | ||
| ``` |
There was a problem hiding this comment.
Formatting was correct to MD spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.