Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improve release steps #711

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nickvergessen
Copy link
Member

No description provided.

Signed-off-by: Joas Schilling <[email protected]>
git push origin v$(version)
git push releases v$(version)
```
8. **Draft a new release** on GitHub in [nextcloud-releases/talk-desktop](https://github.com/nextcloud-releases/talk-desktop/releases)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This actually needs to be done on nextcloud/ otherwise there is an error/warning that no PRs can be found for the commits.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can draft the release for a not pushed version. Or I didn't understand your comment.

git push releases v$(version)
```
7. **Draft a new release** on GitHub in [nextcloud-releases/talk-desktop](https://github.com/nextcloud-releases/talk-desktop/releases)
Built-in Talk in binaries is updated to $(talkVersion) Talk changelog: https://github.com/nextcloud/spreed/blob/$(talkVersion)/CHANGELOG.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Built-in Talk in binaries is updated to $(talkVersion) Talk changelog: https://github.com/nextcloud/spreed/blob/$(talkVersion)/CHANGELOG.md
Built-in Talk in binaries is updated to Talk v$(talkVersion)

Built-in Talk in binaries is updated to $(talkVersion) Talk changelog: https://github.com/nextcloud/spreed/blob/$(talkVersion)/CHANGELOG.md
```
3. Commit `CHANGELOG.md`
4. Update version in `package.json` and `package-locked.json` using npm:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
4. Update version in `package.json` and `package-locked.json` using npm:
4. Update version in `package.json` and `package-lock.json` using npm:

```sh
npm version patch --no-git-tag
```
3. Commit `package.json` and `package-locked.json`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
3. Commit `package.json` and `package-locked.json`
3. Commit `package.json` and `package-lock.json`

git push origin v$(version)
git push releases v$(version)
```
8. **Draft a new release** on GitHub in [nextcloud-releases/talk-desktop](https://github.com/nextcloud-releases/talk-desktop/releases)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can draft the release for a not pushed version. Or I didn't understand your comment.

Comment on lines +173 to +179
```md
## What's Changed

<details>
<!-- Generated content -->
</details>
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting was correct to MD spec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants