fix: make deleteOldFiles / moveNewVersionInPlace more robust #594
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't do any write operations on files or direcories within RDI.
This will make the Updater more robust in FreeBSD and NFS environments (possibly others but those are the known ones).
Fixes #158
Avoids the problem that arose in #517 due to #515 by keeping the memory usage minimal by doing all the exclusions first, not directly converting the iterator to an array, and so the the resulting array sizes stay minimal.
Verified to work on FreeBSD+NFS web hosting provided by https://hostpoint.sh
Verified to work with 72,000+ objects in the
apps/
folder (600+ directories containing 120 files each) without exceeding amemory_limit
of 256M.What this does:
recursiveDelete()
deleteOldFiles()
&moveWithExclusions()
Notes:
createBackup()
&checkWritePermissions()
too, but less critical since deletions/renames aren't taking place in thoseRefs:
Cc: @caco3