Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

post-release dev bump version and snapshots #356

Merged
merged 1 commit into from
Oct 30, 2023
Merged

post-release dev bump version and snapshots #356

merged 1 commit into from
Oct 30, 2023

Conversation

sateeshperi
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/methylseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@sateeshperi sateeshperi requested a review from a team as a code owner October 29, 2023 14:36
@github-actions
Copy link

github-actions bot commented Oct 29, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit d65d8aa

+| ✅ 154 tests passed       |+
#| ❔   4 tests were ignored |#

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-10-29 14:38:33

@sateeshperi sateeshperi merged commit fb8ff2e into nf-core:dev Oct 30, 2023
8 checks passed
edmundmiller
edmundmiller reviewed Oct 30, 2023
View reviewed changes
assets/multiqc_config.yml
@@ -1,7 +1,7 @@
report_comment: >
This report has been generated by the <a href="https://github.com/nf-core/methylseq/releases/tag/2.5.0" target="_blank">nf-core/methylseq</a>
This report has been generated by the <a href="https://github.com/nf-core/methylseq/releases/tag/2.6.0dev" target="_blank">nf-core/methylseq</a>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these need to be dev

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya i was confused about it.....I saw that fetchngs actually got rid of this file ? any idea why it was not needed there and is needed in this pipeline ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

part of the new refactoring i guess ?

@edmundmiller edmundmiller added this to the 2.6.0 milestone Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edmundmiller edmundmiller edmundmiller left review comments

@FriederikeHanssen FriederikeHanssen FriederikeHanssen approved these changes

@FelixKrueger FelixKrueger Awaiting requested review from FelixKrueger FelixKrueger is a code owner automatically assigned from nf-core/methylseq

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sateeshperi @FriederikeHanssen @edmundmiller