Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy components #321

Merged
merged 6 commits into from
May 13, 2024

Conversation

jonasscheid
Copy link
Collaborator

@jonasscheid jonasscheid commented May 12, 2024

This PR gets rid of a bunch of legacy code and related issues with them #245 #248 #278. This involves the subworkflows refine_fdr, include_proteins, predict_class1 and predict_class2 with all the attached python scripts. The HLA prediction logic and variant handling will we synced with the nf-core/epitopeprediction pipeline in the future.

Most importantly, the ID workflow and quant workflow is not affected by this PR.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/mhcquant branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Copy link

github-actions bot commented May 12, 2024

nf-core lint overall result: Passed ✅

Posted for pipeline commit bb9ff54

+| ✅ 233 tests passed       |+

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-05-12 19:07:11

Copy link
Collaborator

@marissaDubbelaar marissaDubbelaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

modules/local/openms_percolatoradapter.nf Show resolved Hide resolved
@jonasscheid jonasscheid merged commit 4a4f835 into nf-core:dev May 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants