Skip to content

Commit

Permalink
Hierarchy of tests applied in order (#3679)
Browse files Browse the repository at this point in the history
* Add wait-for-status workflow

* Rename and tidy all GHA workflows for branch protection

* Changing some stuff to kick off real CI/CD

* Apply suggestions from code review

Co-authored-by: Harshil Patel <[email protected]>

* Update .github/workflows/code-linting.yml

Co-authored-by: Harshil Patel <[email protected]>

* Should reduce concurrent burden at the expense of time. Code is required to lint before running. This will help us during hackathons etc when there is a high burden on the GHA runners, but will be slower in general use.

Changes:
 - linting and testing in one GHA file
 - Linting is required to pass before pytest or nf-test runs
 - Check for changes only happens once

* Fix dependencies in GHA

* Remove files again

* More dependency fixes

* Correct nf-test filtering yaml

* Change to fix-linting for consistency

* Bump setup-python version to v4

* bump eWaterCycle/setup-singularity to v7

* Add final job to test for pass status of all previous jobs

* Add checking for changes to test requirement

* Revert module changes

* Add fake change to FASTQC

* Test in parallel

* Revert "Add fake change to FASTQC"

This reverts commit f050865.

* Change logic to allow skipped processes

* Format changes

* Change logic again

* Change logic again

* Change logic again

* Add debug step to help work it out

* Caught pytest-changes bug

* Reintroduce change to FASTQC module

* Remove debug statements

* Revert "Reintroduce change to FASTQC module"

This reverts commit 197ffeb.

* Mess up FASTQC deliberately to test failures

* Revert "Mess up FASTQC deliberately to test failures"

This reverts commit c28fef4.

* Changed to all lower case

---------

Co-authored-by: Harshil Patel <[email protected]>
  • Loading branch information
adamrtalbot and drpatelh authored Aug 2, 2023
1 parent 716ef30 commit 3a52c17
Show file tree
Hide file tree
Showing 5 changed files with 522 additions and 560 deletions.
43 changes: 0 additions & 43 deletions .github/workflows/code-linting.yml

This file was deleted.

83 changes: 0 additions & 83 deletions .github/workflows/nf-core-linting.yml

This file was deleted.

182 changes: 0 additions & 182 deletions .github/workflows/nf-test.yml

This file was deleted.

Loading

0 comments on commit 3a52c17

Please sign in to comment.