Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Harshil Patel <[email protected]>
  • Loading branch information
adamrtalbot and drpatelh authored Jul 28, 2023
1 parent f8e5c94 commit 628df3e
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 9 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/nf-core-linting.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: nf-core linting
run-name: nf-core linting
run-name: nf-core lint
# This workflow is triggered on pushes and PRs to the repository.
# It runs the `nf-core lint` tests to ensure that the module code meets the nf-core guidelines
on:
Expand All @@ -15,7 +15,7 @@ concurrency:

jobs:
changes:
name: check-for-changes
name: check-changes
runs-on: ubuntu-latest
outputs:
# Expose matched filters as job 'modules' output variable
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/nf-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ concurrency:

jobs:
changes:
name: check-for-changes
name: check-changes
runs-on: ubuntu-latest
outputs:
# Expose matched filters as job 'modules' output variable
Expand All @@ -29,7 +29,7 @@ jobs:
with:
filters: "tests/config/nftest_modules.yml"

nf_test:
nf-test:
runs-on: ubuntu-20.04
name: nf-test
needs: changes
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/pytest-workflow.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: pytest-workflow
run-name: pytest-workflow
name: pytest
run-name: pytest
on:
push:
branches: [master]
Expand All @@ -16,7 +16,7 @@ concurrency:

jobs:
changes:
name: check-for-changes
name: check-changes
runs-on: ubuntu-latest
outputs:
# Expose matched filters as job 'modules' output variable
Expand All @@ -29,9 +29,9 @@ jobs:
with:
filters: "tests/config/pytest_modules.yml"

pytest_workflow:
pytest:
runs-on: ubuntu-20.04
name: pytest-workflow
name: pytest
needs: changes
if: needs.changes.outputs.modules != '[]'
strategy:
Expand Down

0 comments on commit 628df3e

Please sign in to comment.