Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pypgx/runngspipeline #6823

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

Jorisvansteenbrugge
Copy link
Contributor

PR checklist

Closes #5987
This PR adds a new module: pypgx/runngspipeline

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker

@Jorisvansteenbrugge Jorisvansteenbrugge added new module Adding a new module Ready for Review help wanted Extra attention is needed and removed Ready for Review labels Oct 22, 2024
@Jorisvansteenbrugge
Copy link
Contributor Author

For some reason the conda based tests are not working..

@famosab
Copy link
Contributor

famosab commented Oct 31, 2024

Can you run the test locally with the conda profile?
nf-core modules test pypgx/runngspipeline --profile conda -u

@Jorisvansteenbrugge
Copy link
Contributor Author

Can you run the test locally with the conda profile? nf-core modules test pypgx/runngspipeline --profile conda -u

@famosab Thank you for taking a look! I get the same error unfortunately.. I wonder if this is the same issue as #4234 opened by @edmundmiller .

I see this error appears when running tests for subworkflows. Could be that we need to add a name to environment.yml? If two modules in a subworkflow have exactly the same environment.yml I suspect the environment names may clash

While this is not a subworkflow, the nf-test for this module is chained with other modules that use the exact same environment.yml. I am however not sure what the solution is.

@famosab
Copy link
Contributor

famosab commented Nov 1, 2024

In theory that should not happen with nf-test anymore as noted down here: #5836

They seemed to have thought about a fix: #6664

Maybe it is worth asking in the slack since this issue came up a few times :)

@Jorisvansteenbrugge Jorisvansteenbrugge removed the help wanted Extra attention is needed label Nov 11, 2024
@Jorisvansteenbrugge
Copy link
Contributor Author

Jorisvansteenbrugge commented Nov 11, 2024

@famosab Thanks :)

It seems like we are waiting for nextflow-io/nextflow#5489 to get merged. Which should fix the issue (nextflow-io/nextflow#5485)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new module Adding a new module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new module: pypgx/runngspipeline
2 participants