Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve workflow logic for fastq_align_dedup_bismark #7005

Merged
merged 8 commits into from
Nov 18, 2024

Conversation

sateeshperi
Copy link
Contributor

@sateeshperi sateeshperi commented Nov 16, 2024

renaming emit channels as depending on whether skip_deduplication is used, the output is either aligned or dedup bam

@sateeshperi sateeshperi self-assigned this Nov 16, 2024
@sateeshperi sateeshperi changed the title improve workflow logic improve workflow logic for fastq_align_dedup_bismark Nov 17, 2024
Copy link
Member

@mahesh-panchal mahesh-panchal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only issue is the use of it. It would be better if it were an informative variable name.

@sateeshperi sateeshperi added this pull request to the merge queue Nov 18, 2024
Merged via the queue into master with commit af84433 Nov 18, 2024
12 of 13 checks passed
@sateeshperi sateeshperi deleted the fix/fastq_align_dedup_bismark branch November 18, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants